Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3119 heart #3160

Merged
merged 5 commits into from
Mar 28, 2023
Merged

3119 heart #3160

merged 5 commits into from
Mar 28, 2023

Conversation

cakekoa
Copy link
Contributor

@cakekoa cakekoa commented Mar 28, 2023

What does this PR do?

Fixes part of #3119 by passing Agent ID to the HTTPIslandAPIClient

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (876d06b) 72.33% compared to head (88897f1) 72.33%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3160      +/-   ##
===========================================
- Coverage    72.33%   72.33%   -0.01%     
===========================================
  Files          462      462              
  Lines        13202    13203       +1     
===========================================
  Hits          9550     9550              
- Misses        3652     3653       +1

see 18 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mssalvatore mssalvatore merged commit eb3abd8 into develop Mar 28, 2023
@mssalvatore mssalvatore deleted the 3119-heart branch March 28, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mssalvatore mssalvatore mssalvatore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cakekoa @mssalvatore